On Wed, Jun 15, 2011 at 06:55:38PM -0700, Andrew Evans wrote:
> When an error is encountered while parsing flows from a file, ovs-ofctl 
> doesn't
> print the flow it can't parse, so it's not always obvious which flow is 
> causing
> the error. Print the flow before the error message to make it clear.

Could you write a helper function to do the job of this:

            if (verbose) {
                fprintf(stderr, "%s:\n", str_);
            }
            ovs_fatal(0, "must specify an action");

I think it's OK at that point.  But in the long run it might be better
to either just pass back the error string to the caller or to pass in
a file name and line number to include in the error message.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev

Reply via email to