On Wed, Jun 08, 2011 at 02:04:11PM -0700, Jesse Gross wrote: > On Wed, Jun 8, 2011 at 1:47 PM, Ben Pfaff <b...@nicira.com> wrote: > > On Wed, Jun 08, 2011 at 01:05:45PM -0700, Jesse Gross wrote: > >> On Mon, Jun 6, 2011 at 12:41 PM, Ben Pfaff <b...@nicira.com> wrote: > >> > ovs-vsctl is carefully written to avoid races in database access. ??It is > >> > much simpler to just call it than to reimplement its capabilities. > >> > > >> > This eliminates the requirement that bridges managed by ovs-brcompatd > >> > have > >> > no ports at ovs-brcompatd startup time. ??It also eliminates races > >> > between > >> > competing brctl and ovs-vsctl processes. > >> > >> There are some new warnings after this patch (that look real): > >> vswitchd/ovs-brcompatd.c:522: warning: 'br_vlan' is used uninitialized > >> in this function > >> vswitchd/ovs-brcompatd.c:522: warning: 'br_vlan' is used uninitialized > >> in this function > > > > You're right. ??How's this look? ??Does it fix the warning for you? ??(My > > GCC doesn't warn either way.) > > Looks reasonable to me and fixes the problem, thanks.
Thanks, I added a Tested-by: for you and pushed. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
