On Tue, Jun 07, 2011 at 06:22:03PM -0700, Ethan Jackson wrote: > The patch seems fine. I had one thought which may or may not be valuable. > > In reading send_ifindex_reply() and get_bridge_intefaces() I thought > that it might be valuable to implement a function which converts a " > \t\r\n" delimited string to a sset. Then send_ifindex_reply() could > take a sset and would be a bit cleaner. Seems like it would be useful > in several places.
You're probably right. What I liked about using strtok_r() directly was that it was in-place. I think I'll leave this as-is for now. We can change it later if it leads to further simplifications. I'll push this series in a few minutes. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
