On Thu, Jun 2, 2011 at 5:04 PM, Ben Pfaff <[email protected]> wrote: > On Thu, Jun 02, 2011 at 04:59:15PM -0700, Jesse Gross wrote: >> For most of our kernel module we support back to 2.6.18 but we only >> work with 2.6.26 or newer for CAPWAP. On later kernels support for >> CAPWAP silently disappears. In these situations, emit a warning so >> that people aren't suprised when their tunnels fail. >> >> Signed-off-by: Jesse Gross <[email protected]> > > Acked-by: Ben Pfaff <[email protected]> > > I'm not sure how you interpret comments on # conditions. I tend to > interpret them as the GNU coding standards say (see below) in which > case the comment on #endif is now wrong. But some people seem to > write them exactly opposite the way that GNU specifies.
I usually interpret them as telling me which condition that I need to look at because, as you say, people are not consistent. However, I try to write them in accordance with the GNU standards. I didn't mean to change this, so I'll reverse it before I push. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
