On Thu, Jun 02, 2011 at 04:59:15PM -0700, Jesse Gross wrote: > For most of our kernel module we support back to 2.6.18 but we only > work with 2.6.26 or newer for CAPWAP. On later kernels support for > CAPWAP silently disappears. In these situations, emit a warning so > that people aren't suprised when their tunnels fail. > > Signed-off-by: Jesse Gross <[email protected]>
Acked-by: Ben Pfaff <[email protected]> I'm not sure how you interpret comments on # conditions. I tend to interpret them as the GNU coding standards say (see below) in which case the comment on #endif is now wrong. But some people seem to write them exactly opposite the way that GNU specifies. ---------------------------------------------------------------------- Every `#endif' should have a comment, except in the case of short conditionals (just a few lines) that are not nested. The comment should state the condition of the conditional that is ending, _including its sense_. `#else' should have a comment describing the condition _and sense_ of the code that follows. For example: #ifdef foo ... #else /* not foo */ ... #endif /* not foo */ #ifdef foo ... #endif /* foo */ but, by contrast, write the comments this way for a `#ifndef': #ifndef foo ... #else /* foo */ ... #endif /* foo */ #ifndef foo ... #endif /* not foo */ _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
