On Mon, Mar 28, 2011 at 10:18:28PM -0700, Justin Pettit wrote:
> On Mar 28, 2011, at 4:24 PM, Ben Pfaff wrote:
>
> > @@ -141,7 +141,9 @@ def die_if_already_running():
> > ignore_existing_pidfile() has been called, terminate the program."""
> > if _already_running():
> > if not _overwrite_pidfile:
> > - sys.stderr.write("%s: already running\n" % get_pidfile())
> > + msg = "%s: already running as pid %d" % (_pidfile, pid)
> > + logging.error(msg)
> > + sys.stderr.write("%s\n" % msg)
>
> Is "pid" declared somewhere? I didn't see it, but I may have missed it...
Gee, that was dumb. I fixed this:
diff --git a/python/ovs/daemon.py b/python/ovs/daemon.py
index 6240e0d..1e578c4 100644
--- a/python/ovs/daemon.py
+++ b/python/ovs/daemon.py
@@ -141,7 +141,7 @@ def die_if_already_running():
ignore_existing_pidfile() has been called, terminate the program."""
if _already_running():
if not _overwrite_pidfile:
- msg = "%s: already running as pid %d" % (_pidfile, pid)
+ msg = "%s: already running" % _pidfile
logging.error(msg)
sys.stderr.write("%s\n" % msg)
sys.exit(1)
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
