Hi Don, Am 22.10.20 um 07:55 schrieb Don Lewis: > On 22 Oct, Matthias Seidel wrote: >> Hi Jim, >> >> Am 21.10.20 um 20:48 schrieb Jim Jagielski: >>> In the meantime, please review >>> main/writerfilter/source/doctok/resources.xsl on trunk and AOO42X >> Windows Buildbot (AOO42X) just stopped with this error: >> >> 1 module(s): writerfilter need(s) to be rebuilt Reason(s): ERROR: error >> 65280 occurred while making >> /cygdrive/e/slave14/openoffice-win7-41x/build/main/writerfilter/prj When >> you have fixed the errors in that module you can resume the build by >> running: build --from writerfilter > Sounds like > test="string-length($shift)!=0" > doesn't work, which is odd ...
Jim didn't revert the change for trunk/AOO42X yet, find details here: https://ci.apache.org/projects/openoffice/buildlogs/win41x/main/writerfilter/wntmsci12.pro/misc/logs/prj.txt Regards, Matthias > >>>> On Oct 21, 2020, at 2:41 PM, Don Lewis <truck...@apache.org> wrote: >>>> >>>> On 21 Oct, Jim Jagielski wrote: >>>>> OK... so $shift is a number then, or should be? But sometimes $shift >>>>> is simply blank. And we want a black $shift to be evaluated as 0. So >>>>> if all that is correct, could we use number($shift)>0 ? >>>> The input file that generates the header doesn't specifiy $shift in >>>> all cases, so I assume that $shift is treated as an empty string. >>>> >>>> Something I thought would work was test="$shift" since either an empty >>>> string or a zero in a boolean context should evaluate to false, but for >>>> some reason it did not work. >>>> >>>> I didn't stumble across number() in my reading. I don't know what >>>> number() would do in this situation. >>>> >>>>> I'm thinking this isn't the problem though with the failures :/ >>>> Yeah, I think it's probably something else that went in at the same time, >>>> and I think also that build OS vs. deployment OS is part of the mix. >>>> >>>>>> On Oct 21, 2020, at 2:15 PM, Don Lewis <truck...@apache.org> wrote: >>>>>> >>>>>> On 21 Oct, Jim Jagielski wrote: >>>>>>> Should that fix be just: >>>>>>> >>>>>>> <xsl:if test="string-length($shift)!=0"> >>>>>> That would work, but it would produce a different output. It would >>>>>> always put ">> $shift" in the output whenever $shift is nonblank. >>>>>> The change that I committed only puts ">> $shift" in the output if >>>>>> $shift is nonblank and greater than zero. This is what the original >>>>>> version does with older versions of libxslt, or when building on >>>>>> anything newer than CentOS 5. >>>>>> >>>>>>>> On Oct 21, 2020, at 11:37 AM, Jim Jagielski <j...@jagunet.com> wrote: >>>>>>>> >>>>>>>> I don't have it, but that was around the end of Aug right? So right >>>>>>>> around the time when a bunch of stuff was included like updates to >>>>>>>> nss, libxslt, libxml2... >>>>>>>> >>>>>>>> I'm trying to get my head around the logic of >>>>>>>> >>>>>>>> >>>>>>>> https://github.com/apache/openoffice/commit/9510f3847723b65ae47efff8796e6f14f586ce09 >>>>>>>> >>>>>>>>> On Oct 21, 2020, at 10:58 AM, Matthias Seidel >>>>>>>>> <matthias.sei...@hamburg.de> wrote: >>>>>>>>> >>>>>>>>> Hi Jim, >>>>>>>>> >>>>>>>>> Am 21.10.20 um 16:54 schrieb Jim Jagielski: >>>>>>>>>> Let me double check.. I am rebuilding AOO417. Lets see if that >>>>>>>>>> works. >>>>>>>>>> >>>>>>>>>> PS: The one change that DID happen is that I upgraded Vmware >>>>>>>>>> Fusion, which I use to run the CentOS5 VMs. That should NOT make >>>>>>>>>> any difference. But we will see. >>>>>>>>>> >>>>>>>>>> I'll posted when my 4.1.7 test builds are ready. TIA! >>>>>>>>> To be clear, the last version that worked for me was 4.1.8. >>>>>>>>> But it was before we built Release Candidates. >>>>>>>>> >>>>>>>>> Unfortunately, I didn't keep it, but maybe you can upload it again? >>>>>>>>> >>>>>>>>>> --------------------------------------------------------------------- >>>>>>>>>> To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org >>>>>>>>>> For additional commands, e-mail: dev-h...@openoffice.apache.org >>>>>>>>>> >>>>>>>> --------------------------------------------------------------------- >>>>>>>> To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org >>>>>>>> For additional commands, e-mail: dev-h...@openoffice.apache.org >>>>>>>> >>>>>> --------------------------------------------------------------------- >>>>>> To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org >>>>>> <mailto:dev-unsubscr...@openoffice.apache.org> For additional >>>>>> commands, e-mail: dev-h...@openoffice.apache.org >>>>>> <mailto:dev-h...@openoffice.apache.org> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org >>>> <mailto:dev-unsubscr...@openoffice.apache.org> >>>> For additional commands, e-mail: dev-h...@openoffice.apache.org >>>> <mailto:dev-h...@openoffice.apache.org> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > For additional commands, e-mail: dev-h...@openoffice.apache.org >
smime.p7s
Description: S/MIME Cryptographic Signature
