On 21 Oct, Jim Jagielski wrote: > I don't have it, but that was around the end of Aug right? So right around > the time when a bunch of stuff was included like updates to nss, libxslt, > libxml2... > > I'm trying to get my head around the logic of > > > https://github.com/apache/openoffice/commit/9510f3847723b65ae47efff8796e6f14f586ce09
If $shift is blank then "$shift>0" becomes ">0", which is a malformed expression. For some reason, it still works correctly in most cases. The case where it does not is with the latest libxslt when built on CentOS 5. In that cause, when we use the newly built xsltproc to generate headers, one of them is corrupted and results in a build failure when we try to compile with that header. Adding the length check avoids evaluating "$shift>0" when $shift is blank This problem is only a build failure. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
