On Thu, Feb 14, 2013 at 5:18 PM, Pedro Giffuni <p...@apache.org> wrote: > > > > > ----- Messaggio originale ----- >> Da: Rob Weir > >> >> On Thu, Feb 14, 2013 at 4:19 PM, Pedro Giffuni <p...@apache.org> wrote: >>> >>> >>> ----- Messaggio originale ----- >>>> Da: Rob Weir >>> >>>> >>>> And I should say that I'm happy to help if you or anyone else >> wishes >>>> to introduce a "warning mode" or "formula lint" or >> similar feature >>>> that can be optionally enabled to check for possible inadvertent user >>>> errors. >>>> >>> >>> As the guys from the poisonous people video[1] said: >>> >>> "Patches Welcome" >>> >> >> Pedro, I reverted your patch. It was broken in many ways. It is sad >> that with the length of this thread that no one, apparently even you, >> tried to test it. But I did and found: >> > > Now that I recall, I did indeed test that and had noticed some > strange errors but I thought it may be related with my systems' > libc (I am also an OS developer in my spare time). > > > >> 0^0 now returns a #VALUE! error in Calc, breaking compatibility. >> >> 2^(1/3) which should be the cube root of 2 now returns 1. This is >> mathematically incorrect and breaks compatibility. >> >> 2^(-1/3) which should be the reciprocal of the cube root of 3 returns >> 1 with Pedro's changes. This is mathematically incorrect and breaks >> compatibility. >> >> -2^(1/3) which should be an error (returns #VALUE! in AOO 3.4.1) now >> returns 1 with Pedro's changes. This is mathematically incorrect and >> breaks compatibility. >> >> -2^(-1/3) which should be an error (returns #VALUE! in AOO 3.4.1) now >> returns 1 with Pedro's changes. This is mathematically incorrect and >> breaks compatibility. >> > > The last 4 values would've been sufficiently technical to cause the revert > but I should be given the chance to revert it my self. in particular since > the change in >
Sorry, but I believed you when you stated emphatically that you would not revert this patch: https://issues.apache.org/ooo/show_bug.cgi?id=114430#c28 In any case, I don't think anyone should care who reverts. Once a veto has been stated, the code needs to be reverted. Who does it is a matter of convenience. Please don't be offended if someone else does it. -Rob > main/sc/source/core/inc/interpre.hxx > > were correct cleanups. > > Pedro.
