On Sat, Feb 2, 2013 at 8:38 AM, Rob Weir <rabas...@gmail.com> wrote: > On Feb 1, 2013, at 11:01 PM, Tim Williams <william...@gmail.com> wrote: > >> On Fri, Feb 1, 2013 at 8:29 PM, Rob Weir <robw...@apache.org> wrote: >>> On Fri, Feb 1, 2013 at 8:00 PM, Dave Fisher <dave2w...@comcast.net> wrote: >>>> >>>> On Feb 1, 2013, at 3:46 PM, Rob Weir wrote: >>>> >>>>> On Fri, Feb 1, 2013 at 6:40 PM, Rob Weir <robw...@apache.org> wrote: >>>>>> -1 >>>>> >>>>> I've reverted that commit. Getting this wrong could have serious >>>>> repercussions, so let's make sure we get it right. >>>> >>>> Not exactly. You left the link which was the main thing I wanted to add! A >>>> full revert would have been anti-social. The sociable thing is to ask the >>>> committer to do it. It's their commit and we are all in this together. OK. >>> >>> IMHO, the sociable thing is not to feel such exclusive ownership over >>> one's commit that one would be offended if someone else reverted it >>> because they thought it was harmful. We are all in this together, >>> right? >> >> Nope. It's universally uncool to revert someone else's commit. You >> raised the -1, let *them* do the revert, after you've provided >> convincing rationale to the community... > > Then count me uncool then. I did it and I'd do it again in similar > circumstances. It is easier to apologize to David later If I'm wrong > then for us to have the trademark legally invalidated if I was right > and did not act quickly.
I'm not sure what to say. By "uncool" I meant, it's socially unacceptable around here (the ASF) and, yet, your not only ok with that but you'd "do it again". The timeliness wasn't as grave as you intimate - some reasonable time could have been allowed. Please don't revert other's commits in the future... --tim
