This iteration of BeagleV hardware is canceled <https://beaglev.org/>. Given the friction of landing PR#3965, I'm just going to abandon it and mark that CL closed and will be unsubscribing from the lists. There's probably nothing worth heroic efforts to preserve; only a few of those 108 commits were real work with the rest just feeding the machine. That basic PR will be needed by the likes of SiFive Unmatched and other RISC-V hardware.
The NuttX tech is interesting, but I spent an unreasonable amount of time chasing ghosts in the build system and the culture. A style guide that's so complex that you can't teach it to a machine and blocking submits because unrelated files have C99 comments inside an embedded string is just not a fit for me. Thanx to those of you that genuinely tried to help onboard a new dev. Good luck to the project on your journey to be accepted by Apache. RJL On Wed, Jun 23, 2021 at 10:03 AM Abdelatif Guettouche < abdelatif.guettou...@gmail.com> wrote: > *So I've kicked that back in, but it appears I have to wait for a > (gasp)human**to push a button*. > > This is actually a Github thing and is outside of our control. It's pretty > new too, so we too have to get used to it. As Nathan said, this only > applies to first time contributors. Subsequent contributions should go a > bit smoother. > > On Wed, Jun 23, 2021, 3:37 PM Nathan Hartman <hartman.nat...@gmail.com> > wrote: > > > On Tue, Jun 22, 2021 at 11:12 PM Robert Lipe <robertl...@gmail.com> > wrote: > > > > > > > > > > > > > > > The presubmit flips out about C99 comments. Even that's too > radical. > > So > > > > > much for being king. :-) > > > > > > > > You can use C99, but you cannot forgot to follow the Coding Style, // > > > > comments shouldn't be used :-) > > > > > > > > > > It's actually worse than that. You can use C99 comments at the end of a > > > line > > > but not at the beginning > > > > > > frobnicate(); // this is accepted > > > // this is an error > > > > > > That is a bug in nxstyle.c and should be fixed. Please file an issue or, > if > > you're inclined, open a PR... > > > > This is perfectly legal C99. That's 20+ years ago and was widely accepted > > > before then. > > > > > > That's true; however this standard and code style are well established in > > this project; of course anyone can feel free to open a [DISCUSS] thread > to > > propose changes but the onus is obviously on them to persuade the > community > > why it should make those changes. > > > > I see // comments in 48 *.[ch] files. That ship has sailed. > > > > > > That, too, is a bug and should be fixed. > > > > So I've kicked that back in, but it appears I have to wait for a (gasp) > > > human > > > to push a button. I assume this is to stop script kiddies from > submitting > > > bitcoin > > > harvesters in the presubmit, but it really hoses a workflow as it's > like > > > submitting > > > a box of punched cards across the table into the Holy Room where > > computing > > > is done and then awaiting a stack of greenbar with the results later in > > the > > > day. > > > > > > Yes, it's to stop script kiddies with their mining businesses; however > IIRC > > that only applies to your first PR with a project. I think once your PR > > gets merged the next one will go more swiftly. > > > > Hopefully, you're convinced I'm an actual human at this point (even if I > > > complain > > > too much :-) > > > > > > Nope. I'm not convinced. :-p > > > > Jokes aside your participation is greatly appreciated. > > > > Cheers, > > Nathan > > >
