On Tue, Jun 22, 2021 at 11:12 PM Robert Lipe <robertl...@gmail.com> wrote:
> > > > > > > The presubmit flips out about C99 comments. Even that's too radical. So > > > much for being king. :-) > > > > You can use C99, but you cannot forgot to follow the Coding Style, // > > comments shouldn't be used :-) > > > > It's actually worse than that. You can use C99 comments at the end of a > line > but not at the beginning > > frobnicate(); // this is accepted > // this is an error That is a bug in nxstyle.c and should be fixed. Please file an issue or, if you're inclined, open a PR... This is perfectly legal C99. That's 20+ years ago and was widely accepted > before then. That's true; however this standard and code style are well established in this project; of course anyone can feel free to open a [DISCUSS] thread to propose changes but the onus is obviously on them to persuade the community why it should make those changes. I see // comments in 48 *.[ch] files. That ship has sailed. That, too, is a bug and should be fixed. So I've kicked that back in, but it appears I have to wait for a (gasp) > human > to push a button. I assume this is to stop script kiddies from submitting > bitcoin > harvesters in the presubmit, but it really hoses a workflow as it's like > submitting > a box of punched cards across the table into the Holy Room where computing > is done and then awaiting a stack of greenbar with the results later in the > day. Yes, it's to stop script kiddies with their mining businesses; however IIRC that only applies to your first PR with a project. I think once your PR gets merged the next one will go more swiftly. Hopefully, you're convinced I'm an actual human at this point (even if I > complain > too much :-) Nope. I'm not convinced. :-p Jokes aside your participation is greatly appreciated. Cheers, Nathan
