On Thu, Jun 4, 2020 at 1:19 PM Gregory Nutt <spudan...@gmail.com> wrote: > Why don't we require that the reviewer fill in those sections. The main > reason that they are not filled in now is language barrier issues, not > willingness to contribute. Forcing someone who has marginal English > skills to write prose to your requirements is not a very kind thing to > do to our good, honest, well-meaning contributors. Let's help them. > Let's not make life difficult for them. > > Also, if the reviewer fills out those sections we can (1) assure a > constsistent quality of prose, and (2) it is proof that the reviewer > understands the issues will enough and did, in fact, do a real review. > > I have always tried to help contributors by meeting them half way. In > the past, only I ran nxstyle and only I fixed the style errors on > submitted code. That was a courtesy and an act that showed my thanks > for the contributions (I still force push nxstyle fixes to contributors > branches on occasion). Let's go that extra mile rather than be some > kind of an oppressive organization that berates and hassles contributors > who are just trying to do the right thing.
Very good points there. I like the idea of making it a collaborative effort between the contributors and the reviewers. Nathan
