On Thu, Jun 4, 2020 at 11:54 AM Gregory Nutt <spudan...@gmail.com> wrote: > >> See > >> https://github.com/nuttx-to-asf/incubator-nuttx/commit/b496ee7ff9adeaa9020e7b07efed8198d4e8e623 > >> > > > > The is HORRIBLE!!!!!!!!!!! God help us. > Full disclosure: I am the guy with the "lack of working project > experience and vision" who correct that original, horrible template. > I did that with full support and encourgment of all the other people > "lack of working project experience and vision" that I spoke to. The > current template is based on the template used by Sony. I for one, and > I suspect may others, with vote against such an abomination of a template.
I think we should keep the template simple. If it's too complicated, or too many things to fill out, no one will do it. Currently we have three headings: ## Summary ## Impact ## Testing Maybe that should be changed to: ## Changes ## Release Notes ## Testing The purpose of these sections: ## Changes Document the change from a NuttX developer's perspective. (In the past, this went into the CHANGES file.) ## Release Notes Proposed text for the next version's release notes, to document the change from a user's perspective. ## Testing Explain what (if anything) you did to test the changes. But all of this is worthless if the committers don't enforce it. If a PR lacks these sections filled in, the committers who review it should request it to be filled in. Nathan
