I'm confused about commit edb0ce2d5afa8a0905bd4536ac39eaf1819dfc56:
"build: Don't need use $(DELIM) in include statement"

This changes various lines in Make.defs from this:
     include wireless$(DELIM)spirit$(DELIM)drivers$(DELIM)Make.defs
to this:
     include wireless/spirit/lib/Make.defs

Don't we need $(DELIM) to support builds on Windows?

On windows, we get GNU Make from GNUWin32.  It understands both forward and backward slashes, at least as long as they are relative paths.  I merged this change but too many files were in it to review properly or to guarantee that all of the changes are correct.  It should be correct to remove the $(DELIM) from Make include since the GNU make already depends on support of the forward slash delimiter.

But other cases are more complex.  if any CMD.exe tools or any native toolchain is used, then they will depend on having backslashes.

Also,l you question only applies form the Windows native build. When you are working with a POSIX environment on Windows (like Cywin or MSYS2), then normal forward slashes are always used unless you are using a Windows native tool chain such as the one from ARM Embedded (but would never be a problem if you use a toolchain built under Cygwin or MSYS2 using the buildroot repository).

Unfortunately, no one is maintaining the Windows native build now so there is no way to know if this will add more breakage to the Windows native build.  I tried it a couple of months ago.  I fixed a few things but there is still extensive breakage in the build system for  the native build that has been introduced lately. There no single show stopper but a thousand cuts.  I was able to hobble together a complete build .  But change like this are very likely to add to that debt of breakage.

Some time back we actually voted to keep the Windows native build in place, even though it is not fully functional or ready for prime time.  We did mark it as EXPERIMENTAL.  The idea is that some champion for this build would emerge and polish off the fine detailed problems.  That champion has yet to arise.  As the breakage builds up, we might want to revisit that vote someday.



Reply via email to