On Sun, May 24, 2020 at 11:27 AM Gregory Nutt <spudan...@gmail.com> wrote: > > I'm confused about commit edb0ce2d5afa8a0905bd4536ac39eaf1819dfc56: > > "build: Don't need use $(DELIM) in include statement" > > > > This changes various lines in Make.defs from this: > > include wireless$(DELIM)spirit$(DELIM)drivers$(DELIM)Make.defs > > to this: > > include wireless/spirit/lib/Make.defs > > > > Don't we need $(DELIM) to support builds on Windows? > > On windows, we get GNU Make from GNUWin32. It understands both forward > and backward slashes, at least as long as they are relative paths. I > merged this change but too many files were in it to review properly or > to guarantee that all of the changes are correct. It should be correct > to remove the $(DELIM) from Make include since the GNU make already > depends on support of the forward slash delimiter. > > But other cases are more complex. if any CMD.exe tools or any native > toolchain is used, then they will depend on having backslashes.
Ok. We'll just have to keep an eye out for any Windows-related feedback. I don't build on Windows myself, so I can't say anything definitive. I would have preferred to keep using $(DELIM) for all directory separators, even if not required, because that doesn't require having to know and remember which cases need it and which don't, but that's just a matter of style I suppose. The opposite argument could be made too, and I don't think there's a right or wrong answer here. Fair enough... Thanks, Nathan
