patacongo commented on issue #12: nxstyle improvements with No tooling URL: https://github.com/apache/incubator-nuttx/pull/12#issuecomment-569422728 The use of '-m 99' in the testing is a little odd. I usuaully use -m 86. This probably raises some tool use questions. The coding standard says: Line Width. Text should not extend past column 78 in the typical C source or header file. Sometimes the nature of the content of a file may require that the lines exceed this limit. This often occurs in header files with naturally long definitions. If the line width must extend 78 lines, then some wider line width may be used in the file provided that it is used consistently. This should match the width of the block comments: Block Comments. Each grouping in the file is separated with a block comment. The block comment consists of: A line that consists of the opening C comment (/*) followed by a series of asterisks extending to the length of the line (usually to column 78). The name of the grouping, starting at column 4. An asterisk preceives the name of the grouping in column 1. A line that consists of the closing C comment (*/) at the end of the line (usually column 78) preceded by a series of asterisks extending to column 1. So picking any fixed value will cause long lines to be missed OR many invalid "long line" error reports. Ideally, we should parse the file first, look at the block comments, make sure that they are the same width, and set the maximum line with automatically.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
