patacongo edited a comment on issue #12: nxstyle improvements with No tooling URL: https://github.com/apache/incubator-nuttx/pull/12#issuecomment-569422025 I have already review this in its previous incarnation. So I give my approval nw. I don't know if we can approvals from the other people on the list. There is no workflow governing tools in nuttx/tools or apps/tools. C tools should follow C coding standard and the committer should satisfy themselves that the changes are functional. These change does not seem to affect the coding standard verification logic, only the form of error reporting so it is low risk. So I would think that if/when you, @xiaoxiang781216 (and Haitao), are satisfied with the change, I think you should go ahead with the merge. When there are changes to nxstyle that do affect the detection of problems, there is some very careful testing should be done to (1) assure that the change detects the problem and (2) does not introduce false alarms. I can share how I do that when the time is right.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
