Greg,

Ok, here's the SAMA5 UART selection and typo fix PR:

https://github.com/apache/incubator-nuttx/pull/13

I fixed the rest of the UARTs too. Will you let me know if you have
improvements? I am happy to update the PR.

cheers
adam

On Fri, Dec 27, 2019 at 3:58 PM Adam Feuer <a...@starcat.io> wrote:

> On Fri, Dec 27, 2019 at 3:39 PM Gregory Nutt <spudan...@gmail.com> wrote:
>
>> #define PIO_UART2_RXD PIO_UART2_RXD_3
>> #define PIO_UART2_TXD PIO_UART2_TXD_3
>>
>
> I'll try that and revert the pinmap.h files.
>
>
>> Certainly you need to remove the '1' form '# undef
>> SAMA5_HAVE_DBGU_CONSOLE 1' in any case.
>>
>
> Thank for catching that, it's a typo.
>
>
>> The changes to arch/arm/src/sama5/sam_serial.c
>> are certainly important bug fixes.  Can you send those (plus the typo
>> fixes) as patches to d...@apache.org -- or submit a PR against
>> github.com/apache/incubator-nuttx?
>>
>
> Yes, I will certainly do that. Do you want them as-is now in a small PR,
> or would you rather have them as part of a larger PR when (hopefully!) get
> the D27 board working?
>
> Re: the Linux code, thanks for the tips especially about the license. I
> will stay out of that. :) What about the Atmel example code? It has an MIT
> license.
>
> cheers
> adam
> --
> Adam Feuer <a...@starcat.io>
>


-- 
Adam Feuer <a...@starcat.io>

Reply via email to