Martin, I really like what I see here. Can you make a PR out of it? Do you have a JIRA to assign PR to or should I create one? (or you can register for a JIRA account if you want...).
Thanks T On Tue, Jan 9, 2024 at 6:16 PM Romain Manni-Bucau <rmannibu...@gmail.com> wrote: > Hi Martin, > > Design looks better for me now (at this "type" thing but guess the > dependency set idea is not liked too so let's keep it), thanks a lot, very > impatient plugins start to embrace this new model (in particular on > configuration side)! > > Side note: we can need to review the new type names before making it live, > the legacy ones are....legacy but new ones can need an agreement but that's > a very small detail. > > Best, > Romain Manni-Bucau > @rmannibucau <https://twitter.com/rmannibucau> | Blog > <https://rmannibucau.metawerx.net/> | Old Blog > <http://rmannibucau.wordpress.com> | Github < > https://github.com/rmannibucau> | > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book > < > https://www.packtpub.com/application-development/java-ee-8-high-performance > > > > > Le mar. 9 janv. 2024 à 17:58, Martin Desruisseaux < > martin.desruisse...@geomatys.com> a écrit : > > > Le 2024-01-09 à 16 h 57, Tamás Cservenák a écrit : > > > > > > Thanks for your effort, I will take a peek at this soon. > > > > > Thanks. Note that commit 1 can be ignored (it is only cleanup), and > > commit 2 (refactoring of DependencyProperties) could be omitted as well > > if PathTypes were provided directly as a Dependency method instead of > > being stored in DependencyProperties. > > > > Martin > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > >
