Il dom 6 gen 2019, 10:32 Hervé BOUTEMY <herve.bout...@free.fr> ha scritto:
> Le samedi 5 janvier 2019, 12:34:30 CET Enrico Olivelli a écrit : > > Travis up and running on Maven Scripting Plugin > > this is the first build with integration tests > > > > mvn verify -Prun-its > > https://travis-ci.org/apache/maven-scripting-plugin/builds/475666300 > > > > This is how the PR looks like: > > https://github.com/apache/maven-scripting-plugin/pull/2 > > > > I think it is a great step forward for contributors > +1 > such a basic setup is sufficient for 90% of our plugins, which have basic > "mvn > -Prun-its verify" requirement > > is it just about the addition of the .travis.yml on any git repository? > You have to add travis configuration file and you have to ask infra to enable it, every committer ( at least I can and I am not special) will be able to change the configuration using Travis Web Ui but only infra can activate the service. Beware that it is not only running 'verify' but also it is implicit in Travis to run mvn install -DskipTests -Djavadoc.skip.. See [1] We could enable multiple java versions and maven version but you are limited to linux and osx, not windows. I think that in our case linux + latest jdk (11 currently) is enough, as the committer will anyway test the patch on maven-box Enrico [1] https://docs.travis-ci.com/user/languages/java/#projects-using-maven > Regards, > > Hervé > > > > > Il giorno sab 5 gen 2019 alle ore 10:35 Enrico Olivelli > > > > <eolive...@gmail.com> ha scritto: > > > Il sab 5 gen 2019, 08:48 Hervé BOUTEMY <herve.bout...@free.fr> ha > scritto: > > >> Le samedi 5 janvier 2019, 08:10:51 CET Olivier Lamy a écrit : > > >> > On Sat, 5 Jan 2019 at 12:39, Tibor Digana <tibordig...@apache.org> > wrote: > > >> > > Manfred, did you see my comment on Slack? > > >> > > Shortly, let's have dedicated machines just only for Maven project > > >> > > with > > >> > > Infra support and one person from our team with Infra permissions > > >> > > just on > > >> > > these machines. There are 6 Windows machine. So 4 Win/Ubuntu for > us. > > >> > > all: WDYT? > > >> > > > >> > No way. Apache Infrastructure is a shared infrastructure. There are > NO > > >> > dedicated machine for any projects. > > >> > The infra budget is shared between project. I'm pretty sure you will > > >> > never > > >> > convince infra of your idea... > > >> > If you have time to waste maybe you can try but ...... :) > > >> > > >> +1 > > >> > > >> Enrico, you wrote > > >> "I see the same setup in Zookeeper and Bookkeeper and github pr plugin > > >> works like a charm (and I partecipated in setting it up)" > > >> > > >> but you never gave any pointer, any demo of what Zookeeper and > Bookkeeper > > >> do with PRs (or I overlooked the email: that may happen...) > > >> can you show us, please? > > > > > > Sure, this is an example of PR on BookKeeper, there are up to 10 checks > > > triggered by github, one on travis which validates the build, without > > > tests, on every supported java version, then you have many ASF jenkins > > > jobs for tests and integration tests Bookkeeper tests are huge and so > we > > > split the test suite in 5 parts, so that it is easier to restart a > single > > > job and not to re run the full suite (we still have some flakes) > > > > > > https://github.com/apache/bookkeeper/pull/1572 > > > > > > If you create a PR you will see that the user has the ability to 'skip' > > > some jobs, maybe because his change is only about the website or about > > > some specific parts. In Bookkeeper we have very strict > review-then-commit > > > rules so every one uses PRs in his every day activity on BK. > > > > > > On Zookeeper we have a single precommit job which builds PRs and now we > > > are also enabling Travis this month (the project is migrating from Ant > to > > > Maven and so Travis will be easy to use and most usable for non > > > committers) > > > > > > In both of the two projects we have configured the 'trigger phrase' > and we > > > have whitelisted the apache committers github group for such trigger. > > > > > > Currently all of the jobs are triggered even at PR creation and at > > > close/reopen, this can be dangerous. We can skip this for Maven and > > > enable only the trigger phrase. As already said this is not possible > with > > > current maven-box plugin > > > > > > Enrico > > > > > >> Regards, > > >> > > >> Hervé > > >> > > >> > > Cheers > > >> > > Tibor > > >> > > > > >> > > On Sat, Jan 5, 2019 at 12:11 AM Manfred Moser > > >> > > <manf...@simpligility.com> > > >> > > > > >> > > wrote: > > >> > > > I agree with Tibor. I would rather not have to deal with two > > >> > > > different > > >> > > > CI > > >> > > > systems... > > >> > > > > > >> > > > Manfred > > >> > > > > > >> > > > Tibor Digana wrote on 2019-01-04 14:00: > > >> > > > > @Stephen Connolly <steph...@apache.org> > > >> > > > > After such a big investment, especially made on your side, in > > >> > > > > Jenkins > > >> > > > > plugin you developed you do not want to support the GitHub PRs > > >> > > > > and you > > >> > > > > > >> > > > just > > >> > > > > > >> > > > > let be to go with TravisCI just like that? I do not think so! > > >> > > > > T > > >> > > > > > > >> > > > > > > >> > > > > On Fri, Jan 4, 2019 at 7:22 PM Stephen Connolly < > > >> > > > > > > >> > > > > stephen.alan.conno...@gmail.com> wrote: > > >> > > > >> +1 from me > > >> > > > >> > > >> > > > >> On Fri 4 Jan 2019 at 18:21, Enrico Olivelli > > >> > > > >> <eolive...@gmail.com> > > >> > > > > > >> > > > wrote: > > >> > > > >> > Hi, > > >> > > > >> > I would like to try out Travis on this small plugin: > > >> > > > >> > https://github.com/apache/maven-scripting-plugin > > >> > > > >> > > > >> > > > >> > I have pushed a minimal configuration file > > >> > > > >> > I need to ask to Infra, but I need approval from the > community > > >> > > > >> > and > > >> > > > >> > > >> > > > >> PMCs... > > >> > > > >> > > >> > > > >> > Can I proceed ? > > >> > > > >> > > > >> > > > >> > Enrico > > >> > > > > >> > > > --------------------------------------------------------------------- > > >> > > > > >> > > > >> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > >> > > > >> > For additional commands, e-mail: dev-h...@maven.apache.org > > >> > > > >> > > > >> > > > >> > -- > > >> > > > >> > > >> > > > >> Sent from my phone > > >> > > > > > >> > > > > ------------------------------------------------------------------- > > >> > > > -- > > >> > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > >> > > > For additional commands, e-mail: dev-h...@maven.apache.org > > >> > > >> --------------------------------------------------------------------- > > >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > >> For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > -- > > > > > > > > > -- Enrico Olivelli > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > > -- -- Enrico Olivelli
