+1 I think we should have rat on every build by default, and only avoid it if it ever cause real performance issue (which doesn't seem to happen)
https://issues.apache.org/jira/browse/MPOM-52 created Regards, Hervé Le dimanche 18 mai 2014 14:38:56 Jason van Zyl a écrit : > It's the site phase itself that takes a long time. > > On the commons-vfs core module it's takes little time: > > https://gist.github.com/jvanzyl/69c038c0f100803f10db > > I argue that the release should always be in a ready state to release, all > requirements need to be met at all times in order for this to be the case. > Aside from the surprise factor at release time when something doesn't work. > On May 18, 2014, at 2:15 PM, Bernd Eckenfels <e...@zusammenkunft.net> wrote: > > Currently the Rat Report in the Site phase of commons-vfs takes enormous > > time, for really no good use when the commits are reviewed anyway (and it > > has all kinds of excludes and warnings you manually need to check). > > > > So I argue it would be better to run it only in relase (candidate) builds. > > Not sure if the same process applies to maven development. > > > > Greetings > > Bernd > > > > Am 18.05.2014 um 19:43 schrieb "Jason Pyeron" <jpye...@pdinc.us>: > >>> -----Original Message----- > >>> From: Jason van Zyl > >>> Sent: Sunday, May 18, 2014 13:05 > >>> > >>> Right now though we require all files to have license headers > >>> we do not run the check to verify this by default. > >> > >> Can it be turned off by option? > >> > >>> It kept dinging me until I turned it on by default in Maven > >>> core. Someone currently trying to contribute has no idea this > >>> is a requirement and is not told so because it doesn't run by > >>> default. If it's required how about we just run all the time > >>> everywhere? > >> > >> What phase? > >> > >>> I would like to change the POMs so that it always runs. > >>> Having to run RAT separately is a usability fail. The chances > >>> of anyone contributing knowing they have to run it are pretty > >>> close to zero. > >>> > >>> Anyone see a reason not to always run it? > >> > >> How much time do they take (add)? > >> > >> -Jason > >> > >> -- > >> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- > >> - - > >> - Jason Pyeron PD Inc. http://www.pdinc.us - > >> - Principal Consultant 10 West 24th Street #100 - > >> - +1 (443) 269-1555 x333 Baltimore, Maryland 21218 - > >> - - > >> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- > >> This message is copyright PD Inc, subject to license 20080407P00. > >> > >> > >> > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >> For additional commands, e-mail: dev-h...@maven.apache.org > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org > > Thanks, > > Jason > > ---------------------------------------------------------- > Jason van Zyl > Founder, Apache Maven > http://twitter.com/jvanzyl > http://twitter.com/takari_io > --------------------------------------------------------- > > You are never dedicated to something you have complete confidence in. > No one is fanatically shouting that the sun is going to rise tomorrow. > They know it is going to rise tomorrow. When people are fanatically > dedicated to political or religious faiths or any other kind of > dogmas or goals, it's always because these dogmas or > goals are in doubt. > > -- Robert Pirzig, Zen and the Art of Motorcycle Maintenance --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
