On May 18, 2014, at 1:43 PM, Jason Pyeron <jpye...@pdinc.us> wrote: >> -----Original Message----- >> From: Jason van Zyl >> Sent: Sunday, May 18, 2014 13:05 >> >> Right now though we require all files to have license headers >> we do not run the check to verify this by default. >> > > Can it be turned off by option? >
It has an option to ignore the errors: http://creadur.apache.org/rat/apache-rat-plugin/check-mojo.html >> It kept dinging me until I turned it on by default in Maven >> core. Someone currently trying to contribute has no idea this >> is a requirement and is not told so because it doesn't run by >> default. If it's required how about we just run all the time >> everywhere? > > What phase? It runs in the validate phase. > >> >> I would like to change the POMs so that it always runs. >> Having to run RAT separately is a usability fail. The chances >> of anyone contributing knowing they have to run it are pretty >> close to zero. >> >> Anyone see a reason not to always run it? > > How much time do they take (add)? Negligible in the grand scheme of things. I don't notice on Maven core which is still relatively small. For anything here I don't think anyone is going to notice it running. > > -Jason > > -- > -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- > - - > - Jason Pyeron PD Inc. http://www.pdinc.us - > - Principal Consultant 10 West 24th Street #100 - > - +1 (443) 269-1555 x333 Baltimore, Maryland 21218 - > - - > -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- > This message is copyright PD Inc, subject to license 20080407P00. > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > Thanks, Jason ---------------------------------------------------------- Jason van Zyl Founder, Apache Maven http://twitter.com/jvanzyl http://twitter.com/takari_io --------------------------------------------------------- believe nothing, no matter where you read it, or who has said it, not even if i have said it, unless it agrees with your own reason and your own common sense. -- Buddha
