[
https://issues.apache.org/jira/browse/SOLR-5488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13830939#comment-13830939
]
Erick Erickson commented on SOLR-5488:
--------------------------------------
Mark's comment lead me to apply the patch fresh to 4x and run IntelliJ's
analysis on it. Here's what that process found:
1> Some possible class cast exceptions, but I don't think these are all that
important.
2> ExpressionFactory about line 166. The escapedCharacter variable is always
true in the test, at the end of the loop there's this coed:
if (escapedCharacter) {
escapedCharacter=false;
}
3> FieldFacetTest, line 1191. The variable 'b' cannot be false inside the for
loop. This doesn't matter, but it's useless there.
4> SolrCore, line 2269.
if (cd != null) {
if (null != cd && cd.getCoreContainer() != null) {
cd is never null.
5> StatsCollectionSupplierFactory, line 454. Claim is that src can never be a
DateFieldSource. DateFieldSource extends LongFieldSource which is tested above.
6> Mark's comment, this line is removing something other than a String from a
Set<String>:
if (qfr.getDependencies().remove(queryFacet)) {
I'm not sure how relevant some of these are, but they're probably worth
examining.
> Fix up test failures for Analytics Component
> --------------------------------------------
>
> Key: SOLR-5488
> URL: https://issues.apache.org/jira/browse/SOLR-5488
> Project: Solr
> Issue Type: Bug
> Affects Versions: 5.0, 4.7
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Attachments: SOLR-5488.patch, SOLR-5488.patch
>
>
> The analytics component has a few test failures, perhaps
> environment-dependent. This is just to collect the test fixes in one place
> for convenience when we merge back into 4.x
--
This message was sent by Atlassian JIRA
(v6.1#6144)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
