[
https://issues.apache.org/jira/browse/SOLR-5342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13793684#comment-13793684
]
Shawn Heisey commented on SOLR-5342:
------------------------------------
I can do it, I just wasn't sure whether I *should*. My search method was to
use Eclipse to locate usages of Throwable.getMessage().
I saw cases where getMessage() is used to construct logging messages, but the
actual exception was not included in the logger call. I also did not touch any
test code. I'll put together a patch that changes every instance I can find,
and then we can discuss whether any need to be reverted.
> In some places, when a caught exception is re-thrown, the original exception
> is not included
> --------------------------------------------------------------------------------------------
>
> Key: SOLR-5342
> URL: https://issues.apache.org/jira/browse/SOLR-5342
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 4.5
> Reporter: Shawn Heisey
> Assignee: Shawn Heisey
> Priority: Minor
> Fix For: 4.5.1, 4.6, 5.0
>
> Attachments: SOLR-5342.patch
>
>
> ShardHandlerFactory#newInstance catches exceptions and rethrows them. It was
> including the message from the caught exception, but not including the actual
> exception. This made it difficult to figure out the root cause for an SSL
> initialization error.
> While fixing this, I discovered other places that are missing this as well.
> Some of them I elected not to fix, either because it's catching IOException
> (which normally provides good messages), or because it was in a location that
> might get called frequently, which would greatly increase logging output.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
