[ 
https://issues.apache.org/jira/browse/SOLR-5342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13793665#comment-13793665
 ] 

Robert Muir commented on SOLR-5342:
-----------------------------------

{quote}
While fixing this, I discovered other places that are missing this as well. 
Some of them I elected not to fix, either because it's catching IOException 
(which normally provides good messages), or because it was in a location that 
might get called frequently, which would greatly increase logging output.
{quote}

If you won't fix these, I will find them all and fix them myself. It does not 
matter if the message is good and logging does not matter either: hiding 
stacktraces is seriously wrong.

> In some places, when a caught exception is re-thrown, the original exception 
> is not included
> --------------------------------------------------------------------------------------------
>
>                 Key: SOLR-5342
>                 URL: https://issues.apache.org/jira/browse/SOLR-5342
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 4.5
>            Reporter: Shawn Heisey
>            Assignee: Shawn Heisey
>            Priority: Minor
>             Fix For: 4.5.1, 4.6, 5.0
>
>         Attachments: SOLR-5342.patch
>
>
> ShardHandlerFactory#newInstance catches exceptions and rethrows them.  It was 
> including the message from the caught exception, but not including the actual 
> exception.  This made it difficult to figure out the root cause for an SSL 
> initialization error.
> While fixing this, I discovered other places that are missing this as well.  
> Some of them I elected not to fix, either because it's catching IOException 
> (which normally provides good messages), or because it was in a location that 
> might get called frequently, which would greatly increase logging output.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to