Thank you everyone who tested so far.
As we discussed on the other thread, Dawid found that an important
follow-up fix for LUCENE-10311 was not backported to branch_9_1. We decided
it was worth cancelling this vote and respinning an RC2 with this fix. So
this vote has failed. I will send out a new vote for RC2 tomorrow.
Separately, I noticed a warning in Uwe's build log around my GPG key ("GPG:
gpg: WARNING: This key is not certified with a trusted signature!"). I'm
not sure if this indicates an issue with my new key? Please let me know if
you have any insights/ suggestions -- I found the instructions for setting
up keys to be complex and I may have missed something.
Julie
On Tue, Mar 15, 2022 at 9:11 AM Uwe Schindler <u...@thetaphi.de> wrote:
> Hi Julie,
>
> Thanks for starting the release process! Many thanks for the work of
> fixing smoke tester. I was finally also able to run the smoke tester on my
> private Policeman Jenkins job to test the release (please note
> "-Ptests.multiplier=1" in command line):
> https://jenkins.thetaphi.de/job/Lucene-Release-Tester/12/console
>
> SUCCESS! [1:54:13.620821]
> Finished: SUCCESS
>
> This tested Java 11 and Java 17 (Eclipse Temurin JDK), this is why it took
> approximately 2 hours on the otherwise beefy machine.
>
> I also unzipped the archives and verified Javadocs. Luke started with
> Windows and whitespace in path name. I was able to open an 8.x index from
> the backwards indexes.
>
> Unfortunately I had no time to do a real module system test with a
> project, but I trust the integration tests that we added. Looking forward
> to get responses from Elastic about migration of Lucene and Elasticsearch
> to the Java module system!
>
> Here is my +1 to release!
>
> Uwe
> -----
> Uwe Schindler
> Achterdiek 19, D-28357 Bremen
> https://www.thetaphi.de
> eMail: u...@thetaphi.de
>
> > -----Original Message-----
> > From: Adrien Grand <jpou...@gmail.com>
> > Sent: Tuesday, March 15, 2022 3:32 PM
> > To: Lucene Dev <dev@lucene.apache.org>
> > Subject: Re: [VOTE] Release Lucene 9.1.0 RC1
> >
> > +1 [1:15:46.282120]
> >
> > On Tue, Mar 15, 2022 at 3:19 PM Dawid Weiss <dawid.we...@gmail.com>
> > wrote:
> > >
> > > > Could we change this propertyOrDefault() hack in Gradle to make -D
> have
> > higher prio?
> > >
> > > Perhaps this wasn't explicit - yes, if you modify that method (and
> > > propertyOrDefaultOrEnv) then you can control the "priority" of these
> > > properties.
> > >
> > >
> > > On Tue, Mar 15, 2022 at 3:17 PM Dawid Weiss <dawid.we...@gmail.com>
> > wrote:
> > > >
> > > >
> > > > > @Dawid: Is there any way to make -D and -P the same for gradle?
> Most
> > developers are used to “-D” (as I am), but gradle expects “-P” and the -D
> > support was only added by your hack. Could we change this
> > propertyOrDefault() hack in Gradle to make -D have higher prio?
> > > >
> > > > Gradle doesn't recognize -D (system) properties at all within the
> build. I
> > added it manually for people like you, who are used to it. Typically,
> you'd pass
> > project properties with -P only. I would love to get rid of this -D
> option entirely,
> > eventually...
> > > >
> > > > Dawid
> > > >
> > > > On Tue, Mar 15, 2022 at 2:57 PM Uwe Schindler <u...@thetaphi.de>
> > wrote:
> > > >>
> > > >> Hi,
> > > >>
> > > >>
> > > >>
> > > >> Small correction, I have to pass “-Ptests.multiplier=1”, “-D” does
> not work
> > to override!
> > > >>
> > > >>
> > > >>
> > > >> -P (project prop) takes precedence over -D (system prop) and the
> user’s
> > values in gradle.properties are injected into build as project
> properties.
> > > >>
> > > >>
> > > >>
> > > >> We should also change smoketester.py to pass the nightly with -P
> not -D,
> > because those properties have highest precendence. Otherwise smoke tester
> > can do different things behind the scenes. If you put
> tests.nightly=false into
> > your gradle.properties, smoke tester won’t be able to override
> > > >>
> > > >>
> > > >>
> > > >> @Dawid: Is there any way to make -D and -P the same for gradle? Most
> > developers are used to “-D” (as I am), but gradle expects “-P” and the -D
> > support was only added by your hack. Could we change this
> > propertyOrDefault() hack in Gradle to make -D have higher prio?
> > > >>
> > > >>
> > > >>
> > > >> Uwe
> > > >>
> > > >>
> > > >>
> > > >> -----
> > > >>
> > > >> Uwe Schindler
> > > >>
> > > >> Achterdiek 19, D-28357 Bremen
> > > >>
> > > >> https://www.thetaphi.de
> > > >>
> > > >> eMail: u...@thetaphi.de
> > > >>
> > > >>
> > > >>
> > > >> From: Uwe Schindler <u...@thetaphi.de>
> > > >> Sent: Tuesday, March 15, 2022 1:40 PM
> > > >> To: dev@lucene.apache.org
> > > >> Subject: RE: [VOTE] Release Lucene 9.1.0 RC1
> > > >>
> > > >>
> > > >>
> > > >> Hi,
> > > >>
> > > >>
> > > >>
> > > >> I figured out that you can pass the test args at end of command
> line after
> > the URL. I added -Dtests.multiplier=1 on the run command line in
> jenkins. Hope
> > that helps:
> > > >>
> > > >>
> > > >>
> > > >> Now it starts tests like this:
> > > >>
> > > >> https://jenkins.thetaphi.de/job/Lucene-Release-Tester/11/console
> > > >>
> > > >> run tests w/ Java 11 and testArgs='-Dtests.nightly=true -
> > Dtests.badapples=false -Dtests.multiplier=1'...
> > > >>
> > > >>
> > > >>
> > > >> I will try to do the same on ASF jenkins to prevent the same
> problem,
> > because I am working on setting up the nightly smoketester job for 9.x
> branch.
> > > >>
> > > >>
> > > >>
> > > >> Uwe
> > > >>
> > > >>
> > > >>
> > > >> -----
> > > >>
> > > >> Uwe Schindler
> > > >>
> > > >> Achterdiek 19, D-28357 Bremen
> > > >>
> > > >> https://www.thetaphi.de
> > > >>
> > > >> eMail: u...@thetaphi.de
> > > >>
> > > >>
> > > >>
> > > >> From: Uwe Schindler <u...@thetaphi.de>
> > > >> Sent: Tuesday, March 15, 2022 1:13 PM
> > > >> To: dev@lucene.apache.org
> > > >> Subject: RE: [VOTE] Release Lucene 9.1.0 RC1
> > > >>
> > > >>
> > > >>
> > > >> Hi,
> > > >>
> > > >>
> > > >>
> > > >> I have a problem with running Smoketester (like on every release)
> with
> > Policeman Jenkins. There’s a job to execute smoke tester and it takes as
> > parameters the branch name and the version number (incl. hash).
> > > >>
> > > >>
> > > >>
> > > >> This worked for 9.0, but with 9.1 it hangs endless and does not
> finish:
> > > >>
> > > >> make sure no JARs/WARs in src dist...
> > > >>
> > > >> run "./gradlew --no-daemon check -p lucene/documentation"
> > > >>
> > > >> run tests w/ Java 11 and testArgs='-Dtests.nightly=true -
> > Dtests.badapples=false '...
> > > >>
> > > >>
> > > >>
> > > >> After that nothing happens anymore. The CPUs use a lot at
> beginning, but
> > it hangs at end with one cpu core 100% occupied. From the parameters it
> > enabled -Dtests.nightly=true. Is this wanted or somehow coming from
> > environment.
> > > >>
> > > >>
> > > >>
> > > >> There is one important thing to note: Jenkins has a
> gradle.properties with
> > the following lines (similar on ASF jenkins):
> > > >>
> > > >> org.gradle.parallel=true
> > > >>
> > > >> org.gradle.priority=normal
> > > >>
> > > >> org.gradle.daemon=false
> > > >>
> > > >>
> > > >>
> > > >> org.gradle.workers.max=6
> > > >>
> > > >> tests.jvms=6
> > > >>
> > > >> tests.multiplier=3
> > > >>
> > > >>
> > > >>
> > > >> The “tests.multiplier=3” looks like the problem. I have no idea how
> to stop
> > this, because the gradle properties are injected through the config
> file. Is there
> > a way to pass custom parameters. Maybe we should add
> “-Dtests.multiplier=1”
> > to the command line. At least in combination with “-Dtests.nightly=true”
> this
> > seems to break (see ASF Jenkins which has most nightly jobs taking
> forever)
> > > >>
> > > >>
> > > >>
> > > >> Does anybody complain if I commit a -Dtests.multiplier=1 to the 9.1
> > branch?
> > > >>
> > > >>
> > > >>
> > > >> Uwe
> > > >>
> > > >>
> > > >>
> > > >> -----
> > > >>
> > > >> Uwe Schindler
> > > >>
> > > >> Achterdiek 19, D-28357 Bremen
> > > >>
> > > >> https://www.thetaphi.de
> > > >>
> > > >> eMail: u...@thetaphi.de
> > > >>
> > > >>
> > > >>
> > > >> From: Julie Tibshirani <juliet...@gmail.com>
> > > >> Sent: Tuesday, March 15, 2022 1:57 AM
> > > >> To: dev@lucene.apache.org
> > > >> Subject: [VOTE] Release Lucene 9.1.0 RC1
> > > >>
> > > >>
> > > >>
> > > >> Please vote for release candidate 1 for Lucene 9.1.0
> > > >>
> > > >> The artifacts can be downloaded from:
> > > >> https://dist.apache.org/repos/dist/dev/lucene/lucene-9.1.0-RC1-rev-
> > a6114b532a273e370528675d551d3ddfa02f4679
> > > >>
> > > >> You can run the smoke tester directly with this command:
> > > >>
> > > >> python3 -u dev-tools/scripts/smokeTestRelease.py \
> > > >> https://dist.apache.org/repos/dist/dev/lucene/lucene-9.1.0-RC1-rev-
> > a6114b532a273e370528675d551d3ddfa02f4679
> > > >>
> > > >> The vote will be open for at least 72 hours i.e. until 2022-03-18
> 00:00 UTC.
> > > >>
> > > >> [ ] +1 approve
> > > >> [ ] +0 no opinion
> > > >> [ ] -1 disapprove (and reason why)
> > > >>
> > > >> Here is my +1.
> > > >>
> > > >>
> > > >>
> > > >> Julie
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
> > > For additional commands, e-mail: dev-h...@lucene.apache.org
> > >
> >
> >
> > --
> > Adrien
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
> > For additional commands, e-mail: dev-h...@lucene.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
> For additional commands, e-mail: dev-h...@lucene.apache.org
>
>
