Hi Dawid,
thanks for the feedback. As one step in between we should fix smoketester to pass properties to gradle using -P and not -D. That should be easy to do. Thanks, Uwe ----- Uwe Schindler Achterdiek 19, D-28357 Bremen https://www.thetaphi.de eMail: u...@thetaphi.de From: Dawid Weiss <dawid.we...@gmail.com> Sent: Tuesday, March 15, 2022 3:17 PM To: Lucene Dev <dev@lucene.apache.org> Subject: Re: [VOTE] Release Lucene 9.1.0 RC1 > @Dawid: Is there any way to make -D and -P the same for gradle? Most > developers are used to “-D” (as I am), but gradle expects “-P” and the -D > support was only added by your hack. Could we change this propertyOrDefault() > hack in Gradle to make -D have higher prio? Gradle doesn't recognize -D (system) properties at all within the build. I added it manually for people like you, who are used to it. Typically, you'd pass project properties with -P only. I would love to get rid of this -D option entirely, eventually... Dawid On Tue, Mar 15, 2022 at 2:57 PM Uwe Schindler <u...@thetaphi.de <mailto:u...@thetaphi.de> > wrote: Hi, Small correction, I have to pass “-Ptests.multiplier=1”, “-D” does not work to override! -P (project prop) takes precedence over -D (system prop) and the user’s values in gradle.properties are injected into build as project properties. We should also change smoketester.py to pass the nightly with -P not -D, because those properties have highest precendence. Otherwise smoke tester can do different things behind the scenes. If you put tests.nightly=false into your gradle.properties, smoke tester won’t be able to override @Dawid: Is there any way to make -D and -P the same for gradle? Most developers are used to “-D” (as I am), but gradle expects “-P” and the -D support was only added by your hack. Could we change this propertyOrDefault() hack in Gradle to make -D have higher prio? Uwe ----- Uwe Schindler Achterdiek 19, D-28357 Bremen https://www.thetaphi.de eMail: u...@thetaphi.de <mailto:u...@thetaphi.de> From: Uwe Schindler <u...@thetaphi.de <mailto:u...@thetaphi.de> > Sent: Tuesday, March 15, 2022 1:40 PM To: dev@lucene.apache.org <mailto:dev@lucene.apache.org> Subject: RE: [VOTE] Release Lucene 9.1.0 RC1 Hi, I figured out that you can pass the test args at end of command line after the URL. I added -Dtests.multiplier=1 on the run command line in jenkins. Hope that helps: Now it starts tests like this: https://jenkins.thetaphi.de/job/Lucene-Release-Tester/11/console run tests w/ Java 11 and testArgs='-Dtests.nightly=true -Dtests.badapples=false -Dtests.multiplier=1'... I will try to do the same on ASF jenkins to prevent the same problem, because I am working on setting up the nightly smoketester job for 9.x branch. Uwe ----- Uwe Schindler Achterdiek 19, D-28357 Bremen https://www.thetaphi.de eMail: u...@thetaphi.de <mailto:u...@thetaphi.de> From: Uwe Schindler <u...@thetaphi.de <mailto:u...@thetaphi.de> > Sent: Tuesday, March 15, 2022 1:13 PM To: dev@lucene.apache.org <mailto:dev@lucene.apache.org> Subject: RE: [VOTE] Release Lucene 9.1.0 RC1 Hi, I have a problem with running Smoketester (like on every release) with Policeman Jenkins. There’s a job to execute smoke tester and it takes as parameters the branch name and the version number (incl. hash). This worked for 9.0, but with 9.1 it hangs endless and does not finish: make sure no JARs/WARs in src dist... run "./gradlew --no-daemon check -p lucene/documentation" run tests w/ Java 11 and testArgs='-Dtests.nightly=true -Dtests.badapples=false '... After that nothing happens anymore. The CPUs use a lot at beginning, but it hangs at end with one cpu core 100% occupied. From the parameters it enabled -Dtests.nightly=true. Is this wanted or somehow coming from environment. There is one important thing to note: Jenkins has a gradle.properties with the following lines (similar on ASF jenkins): org.gradle.parallel=true org.gradle.priority=normal org.gradle.daemon=false org.gradle.workers.max=6 tests.jvms=6 tests.multiplier=3 The “tests.multiplier=3” looks like the problem. I have no idea how to stop this, because the gradle properties are injected through the config file. Is there a way to pass custom parameters. Maybe we should add “-Dtests.multiplier=1” to the command line. At least in combination with “-Dtests.nightly=true” this seems to break (see ASF Jenkins which has most nightly jobs taking forever) Does anybody complain if I commit a -Dtests.multiplier=1 to the 9.1 branch? Uwe ----- Uwe Schindler Achterdiek 19, D-28357 Bremen https://www.thetaphi.de eMail: u...@thetaphi.de <mailto:u...@thetaphi.de> From: Julie Tibshirani <juliet...@gmail.com <mailto:juliet...@gmail.com> > Sent: Tuesday, March 15, 2022 1:57 AM To: dev@lucene.apache.org <mailto:dev@lucene.apache.org> Subject: [VOTE] Release Lucene 9.1.0 RC1 Please vote for release candidate 1 for Lucene 9.1.0 The artifacts can be downloaded from: https://dist.apache.org/repos/dist/dev/lucene/lucene-9.1.0-RC1-rev-a6114b532a273e370528675d551d3ddfa02f4679 You can run the smoke tester directly with this command: python3 -u dev-tools/scripts/smokeTestRelease.py \ https://dist.apache.org/repos/dist/dev/lucene/lucene-9.1.0-RC1-rev-a6114b532a273e370528675d551d3ddfa02f4679 The vote will be open for at least 72 hours i.e. until 2022-03-18 00:00 UTC. [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove (and reason why) Here is my +1. Julie
