Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/430#discussion_r207880574
--- Diff: solr/solrj/src/java/org/apache/solr/common/util/XML.java ---
@@ -118,16 +122,16 @@ public final static void writeUnescapedXML(Writer
out, String tag, String val, O
out.write('>');
} else {
out.write('>');
- out.write(val);
+ val.write(out);
out.write('<');
out.write('/');
out.write(tag);
out.write('>');
}
}
- /** escapes character data in val if shouldEscape is true*/
- public final static void writeXML(Writer out, String tag, boolean
shouldEscape, String val, Object... attrs) throws IOException {
+ /** escapes character data in val */
+ public final static void writeXML(Writer out, String tag, String val,
Object... attrs) throws IOException {
--- End diff --
Lets make this work in terms of the existing Writable based impl? (less
code)
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
