Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/430#discussion_r207740065
--- Diff: solr/solrj/src/java/org/apache/solr/common/util/XML.java ---
@@ -126,8 +126,8 @@ public final static void writeUnescapedXML(Writer out,
String tag, String val, O
}
}
- /** escapes character data in val */
- public final static void writeXML(Writer out, String tag, String val,
Object... attrs) throws IOException {
+ /** escapes character data in val if shouldEscape is true*/
+ public final static void writeXML(Writer out, String tag, boolean
shouldEscape, String val, Object... attrs) throws IOException {
--- End diff --
I think this change is redundant; see the previously defined method
"writeUnescapedXML".
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
