[ 
https://issues.apache.org/jira/browse/SOLR-9386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15989359#comment-15989359
 ] 

Steve Rowe commented on SOLR-9386:
----------------------------------

bq. Steve Rowe, could we completely remove that parseProperties method from 
Solr code and just let ZK handle it? I see that there's still some excedption 
handling code there after your change, but IMHO we should let ZK handle any 
problems or throw relevant exceptions.

The exception handling is for the case that there is a missing {{myid}} file, 
which I think is the ordinary case for embedded ZK.  That's why I left it in.

I'll add some logging in the exception handling code and run a manual test to 
see if it gets invoked in that case.

> Upgrade Zookeeper to 3.4.10
> ---------------------------
>
>                 Key: SOLR-9386
>                 URL: https://issues.apache.org/jira/browse/SOLR-9386
>             Project: Solr
>          Issue Type: Task
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Steve Rowe
>            Assignee: Steve Rowe
>             Fix For: 6.6, master (7.0)
>
>         Attachments: SOLR-9386.patch, SOLR-9386.patch, SOLR-9386.patch, 
> zookeeper-3.4.8-upgrade-tests-pass.patch, 
> zookeeper-3.4.9-upgrade-tests-fail.patch
>
>
> Zookeeper 3.4.10 release should be happening fairly soon, and the ZK issue 
> blocking incorporation into Solr (ZOOKEEPER-2383) has a 3.4.10-targetted 
> patch that fixes the test failures problem noted on SOLR-8724.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to