[ 
https://issues.apache.org/jira/browse/SOLR-9708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15683698#comment-15683698
 ] 

Timothy M. Rodriguez commented on SOLR-9708:
--------------------------------------------

I've posted an initial commit that allows the user to override the configured 
highlighter based on the "hl.method" parameter.

Two things I want to highlight:

* The highlighter can no longer safely be statically determined using 
HighlightComponent.getHiglighter since a request parameter can override the 
pre-configured one.  I've marked this usage deprecated as it affects quite a 
few places outside of this change.  Is that okay?

* Use of an enum for collecting all the highlight methods and giving a bit 
extra type safety when switching over the values in the override.  I'm not sure 
if this is out of style and several static String fields is preferred (although 
I personally prefer the former).

> Expose UnifiedHighlighter in Solr
> ---------------------------------
>
>                 Key: SOLR-9708
>                 URL: https://issues.apache.org/jira/browse/SOLR-9708
>             Project: Solr
>          Issue Type: New Feature
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: highlighter
>            Reporter: Timothy M. Rodriguez
>            Assignee: David Smiley
>             Fix For: 6.4
>
>
> This ticket is for creating a Solr plugin that can utilize the new 
> UnifiedHighlighter which was initially committed in 
> https://issues.apache.org/jira/browse/LUCENE-7438



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to