Github user michaelbraun commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/111#discussion_r86893258
  
    --- Diff: 
lucene/highlighter/src/test/org/apache/lucene/search/uhighlight/TestUnifiedHighlighter.java
 ---
    @@ -959,4 +961,84 @@ protected PassageFormatter getFormatter(String field) {
         ir.close();
       }
     
    +  public void testBooleanWithSpanAndOverlappingTerms() throws IOException {
    --- End diff --
    
    I will fix the name of the test to clarify and move to the appropriate 
file. Regarding PhraseHelper, that should probably be a separate issue/commit 
I'd think, no? Agree it should be have package visibility rather than be public.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to