Github user dsmiley commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/111#discussion_r86882518
  
    --- Diff: 
lucene/highlighter/src/test/org/apache/lucene/search/uhighlight/TestUnifiedHighlighter.java
 ---
    @@ -959,4 +961,84 @@ protected PassageFormatter getFormatter(String field) {
         ir.close();
       }
     
    +  public void testBooleanWithSpanAndOverlappingTerms() throws IOException {
    --- End diff --
    
    Can you please simplify this one... it's ultimately testing 
preSpanQueryRewrite... maybe make it clear that it's testing that by naming the 
test method as-such?  Maybe this test should go into 
TestUnifiedHighlighterStrictPhrases as it's pertinent to that and not general 
stuff.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to