[
https://issues.apache.org/jira/browse/LUCENE-7167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15223261#comment-15223261
]
Robert Muir edited comment on LUCENE-7167 at 4/3/16 12:56 PM:
--------------------------------------------------------------
I'll list one solvable problem:
Ryan already mentioned, why do we need all these solid classes? I looked at
this part of geo3d recently because I was looking at how the various 2d
implementations handled quantization and rounding, and so I thought, maybe
geo3d needs to be fixed too in that area.
I had no idea what i was in for: geo3d explicitly discards any edge case
testing. So if its gonna do that, why does it do this ridiculous garbage to try
to "correct" for quantization. If we truncate someone's data at index time this
cannot be undone. It cannot be corrected for. So making this complex
XYZSolidFactory that, produces one of 8 possible XYZ's (which are all public
too!!!! why have a factory!!!!!!!), this is so complex to try to "correct" for
damage we have already done.
It does not work and if any edge cases were being tested at all we should see
that. Removing all of this would be a great simplification for geo3d, it would
remove a ton of public classes.
was (Author: rcmuir):
I'll list some one problem:
Ryan already mentioned, why do we need all these solid classes? I looked at
this part of geo3d recently because I was looking at how the various 2d
implementations handled quantization and rounding, and so I thought, maybe
geo3d needs to be fixed too in that area.
I had no idea what i was in for: geo3d explicitly discards any edge case
testing. So if its gonna do that, why does it do this ridiculous garbage to try
to "correct" for quantization. If we truncate someone's data at index time this
cannot be undone. It cannot be corrected for. So making this complex
XYZSolidFactory that, produces one of 8 possible XYZ's (which are all public
too!!!! why have a factory!!!!!!!), this is so complex to try to "correct" for
damage we have already done.
It does not work and if any edge cases were being tested at all we should see
that. Removing all of this would be a great simplification for geo3d, it would
remove a ton of public classes.
> Re-engineer or remove all of geo3D
> ----------------------------------
>
> Key: LUCENE-7167
> URL: https://issues.apache.org/jira/browse/LUCENE-7167
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Karl Wright
>
> Geo3D has led to a lot of consternation because it has a relatively open API.
> The task is to either drastically restrict it or remove the package entirely.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
