[
https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15128127#comment-15128127
]
Shai Erera commented on SOLR-8621:
----------------------------------
bq. Though both simple MPF and wrapped MPF support should from the end-user
perspective be in the same solr release
Well, Simple for sure because that's what users can do today. No one, as far as
I can tell, define today a compound MP like SortingMP or UpgradeIndexMP without
defining his own MP class which will delegate to them. So introduce
{{MergePolicyFactory}} which can allow you to conveniently do that in
{{solrconfig.xml}} is a new feature. But, we want to get them both out in 5.5,
so no need to argue about it, let's just make it happen. If 5.5 was a week
away, we'd perhaps want to finish working on Simple first, but it's not.
bq. Need we consider the possibility of a custom merge policy factory wrapping
more-than-one merge policy?
Do you mean an MP wrapping an MP wrapping an MP? I am not aware of any MP in
Lucene today that behaves like that, but I think a WrapperMPF should just
seamlessly allow it?
bq. PS: I have pushed all my current changes to master-solr-8621 as per above.
Thanks!
Thanks and I've already rebased. I'll move the classes under *.solr now and get
the next set of changes in reasonable shape and push them. From a multiple
commits standpoint, we can do the following:
* Finish current work stream by introducing Simple/Wrapper etc. Once we're
satisfied with these changes (i.e. willing to commit to trunk/5x) we squash the
commits into one and push to master/branch_5x.
* Handle the warning/error path, by modifying solrconfig.xmls, failing in trunk
and warning in 5x. Push those to master/branch_5x.
* Handle SortingMergePolicy on the other issue.
What do you think?
> solrconfig.xml: deprecate/replace <mergePolicy> with <mergePolicyFactory>
> -------------------------------------------------------------------------
>
> Key: SOLR-8621
> URL: https://issues.apache.org/jira/browse/SOLR-8621
> Project: Solr
> Issue Type: Task
> Reporter: Christine Poerschke
> Assignee: Christine Poerschke
>
> *<mergePolicyFactory> end-user benefits:*
> * Lucene's UpgradeIndexMergePolicy can be configured in Solr
> * (with SOLR-5730) Lucene's SortingMergePolicy can be configured in Solr
> * customisability: arbitrary merge policies including wrapping/nested merge
> policies can be created and configured
> *(proposed) roadmap:*
> * solr 5.5 introduces <mergePolicyFactory> support
> * solr 5.5(\?) deprecates (but maintains) <mergePolicy> support
> * solr 6.0(\?) removes <mergePolicy> support
> +work-in-progress git branch:+
> [master-solr-8621|https://github.com/apache/lucene-solr/tree/master-solr-8621]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
