[
https://issues.apache.org/jira/browse/SOLR-8423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15061880#comment-15061880
]
Anshum Gupta commented on SOLR-8423:
------------------------------------
As I said, the name of the param was just something I put in there.
bq. need to find a better param for supporting deletion without cleaning up of
the instance directory (like right now). In this patch, it's called safedelete.
As far as reusing the current params is concerned, I'll go with your suggestion
and put up another patch. I used CoreAdmin calls directly because I didn't want
to stack up more tasks for the Overseer. It however makes sense to just
refactor the coreadmin call code and reuse that.
P.S: The meaning of 'safedelete' would have been clear through the ref
guide/documentation. The difference between instance/data/index directory can
get a little complicated for users though, specially as we're trying to move
away from Core admin calls being exposed to end users (via http api).
> DELETESHARD should cleanup the instance and data directory, like DELETEREPLICA
> ------------------------------------------------------------------------------
>
> Key: SOLR-8423
> URL: https://issues.apache.org/jira/browse/SOLR-8423
> Project: Solr
> Issue Type: Bug
> Reporter: Anshum Gupta
> Attachments: SOLR-8423.patch
>
>
> DELETESHARD only cleans up the index directory and not the instance/data
> directory. DELETEREPLICA on the other hand cleans up the data and instance
> directory.
> DELETESHARD should clean up the instance and data directory, so that we don't
> leak disk space on executing the command.
> If we think this would break back-compat, though I don't see why this should
> not clean up the instance dir, we should at least provide an option to clean
> up everything and make it default in 6.0.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
