[
https://issues.apache.org/jira/browse/SOLR-8423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15061813#comment-15061813
]
Shalin Shekhar Mangar commented on SOLR-8423:
---------------------------------------------
This is easy for the users. No need to remember what a new vague sounding
parameter does. deleteInstanceDir/deleteDataDir is as explicit as it gets.
What the hell is a safedelete anyway?
# We don't accidentally delete other's data?
# We don't delete our data?
# We ensure that data is actually deleted and cannot be recovered?
If you really want to keep things simple for users, do what deletereplica
already does i.e. deletes instance dir, data dir, index automatically as we did
in SOLR-6072. No switch necessary to control that. If you want to implement a
way to control what gets deleted, implement it for both deleteshard and
deletereplica and even better, just have deleteshard internally call
deletereplica and avoid the code duplication.
> DELETESHARD should cleanup the instance and data directory, like DELETEREPLICA
> ------------------------------------------------------------------------------
>
> Key: SOLR-8423
> URL: https://issues.apache.org/jira/browse/SOLR-8423
> Project: Solr
> Issue Type: Bug
> Reporter: Anshum Gupta
> Attachments: SOLR-8423.patch
>
>
> DELETESHARD only cleans up the index directory and not the instance/data
> directory. DELETEREPLICA on the other hand cleans up the data and instance
> directory.
> DELETESHARD should clean up the instance and data directory, so that we don't
> leak disk space on executing the command.
> If we think this would break back-compat, though I don't see why this should
> not clean up the instance dir, we should at least provide an option to clean
> up everything and make it default in 6.0.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
