[
https://issues.apache.org/jira/browse/LUCENE-6371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14542474#comment-14542474
]
David Smiley commented on LUCENE-6371:
--------------------------------------
I really like this design, because it enables one to build a highlighter that
is accurate (so-called “query debugging”). That’s a huge bonus I wasn’t
expecting from this patch (based on the issue title/description). But I think
something is missing — SpanCollector.collectLeaf doesn’t provide access to the
SpanQuery or perhaps the Term that is being collected.
Might SpanCollector.DEFAULT be renamed to NO_OP? Same for
BufferedSpanCollector.NO_OP. I think NO_OP is more clear as to what this
implementation does.
PayloadSpanCollector should use BytesRefArray instead of an ArrayList<byte[]>;
and it can return this from getPayloads()
What is the purpose of the start & end position params to collectLeaf()? No
implementation uses them (on consumer or implementer side) and I'm not sure how
they might be used.
> Improve Spans payload collection
> --------------------------------
>
> Key: LUCENE-6371
> URL: https://issues.apache.org/jira/browse/LUCENE-6371
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Paul Elschot
> Priority: Minor
> Attachments: LUCENE-6371.patch
>
>
> Spin off from LUCENE-6308, see the comments there from around 23 March 2015.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
