[ 
https://issues.apache.org/jira/browse/SOLR-7134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14338420#comment-14338420
 ] 

Mark Miller commented on SOLR-7134:
-----------------------------------

Thanks shalin.

bq. 1,2

Whoops - lost these in the refactoring for the new patch.

bq. 3

Yup. There are already so many bugs when trying to replicate partially into an 
index, I don't think it's currently worth trying to distinguish here yet. We 
need to back off to something safer and more conservative until we can have 
greater confidence in our tests catching more more easily. Right now they are 
not catching tons of horrible stuff and rather than introduce more bugs trying 
to be careful about when we try a full rep, I'd rather start very conservative 
- one chance at partial rep, then do the safe thing.

bq. 4

Ill look closer, but that's the same code that currently there.

> Replication can still cause index corruption.
> ---------------------------------------------
>
>                 Key: SOLR-7134
>                 URL: https://issues.apache.org/jira/browse/SOLR-7134
>             Project: Solr
>          Issue Type: Bug
>          Components: replication (java)
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>            Priority: Critical
>             Fix For: Trunk, 5.1
>
>         Attachments: SOLR-7134.patch, SOLR-7134.patch, SOLR-7134.patch
>
>
> While we have plugged most of these holes, there appears to be another that 
> is fairly rare.
> I've seen it play out a couple ways in tests, but it looks like part of the 
> problem is that even if we decide we need a file and download it, we don't 
> care if we then cannot move it into place if it already exists.
> I'm working with a fix that does two things:
> * Fail a replication attempt if we cannot move a file into place because it 
> already exists.
> * If a replication attempt during recovery fails, on the next attempt force a 
> full replication to a new directory.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to