[
https://issues.apache.org/jira/browse/SOLR-7134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14338052#comment-14338052
]
Shalin Shekhar Mangar commented on SOLR-7134:
---------------------------------------------
Thanks Mark. Some comments on your latest patch:
# The SolrCoreState.setLastReplicateIndexSuccess is not used anywhere?
# The first time a recovery is requested, it will always force replication
because SolrCoreState.getLastReplicateIndexSuccess will return false
# A replication failure because of connect exception or timeout etc shouldn't
necessarily force a full replication but it looks like it will in this patch
# The SnapPuller.cleanup method releases tmpIndexDir even if
deleteTmpIdxDir=false.
> Replication can still cause index corruption.
> ---------------------------------------------
>
> Key: SOLR-7134
> URL: https://issues.apache.org/jira/browse/SOLR-7134
> Project: Solr
> Issue Type: Bug
> Components: replication (java)
> Reporter: Mark Miller
> Assignee: Mark Miller
> Priority: Critical
> Fix For: Trunk, 5.1
>
> Attachments: SOLR-7134.patch, SOLR-7134.patch, SOLR-7134.patch
>
>
> While we have plugged most of these holes, there appears to be another that
> is fairly rare.
> I've seen it play out a couple ways in tests, but it looks like part of the
> problem is that even if we decide we need a file and download it, we don't
> care if we then cannot move it into place if it already exists.
> I'm working with a fix that does two things:
> * Fail a replication attempt if we cannot move a file into place because it
> already exists.
> * If a replication attempt during recovery fails, on the next attempt force a
> full replication to a new directory.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
