[ 
https://issues.apache.org/jira/browse/LUCENE-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14334937#comment-14334937
 ] 

Terry Smith commented on LUCENE-6229:
-------------------------------------

[~rcmuir] Sorry for excluding that scenario, it wasn't intentional.

If you all decide to keep getChildren(), then I'd love to get the contract 
described so people know what to expect.

I think these statements are correct:

# Scorer.getChildren() returns the immediate child scorers
# A returned scorer may be 
## unpositioned (never had next() or advance() called on it)
## positioned on a valid document that is before, on, or after the current 
document
## exhausted and thus positioned at NO_MORE_DOCS
# You MUST NOT call next() or advance() on the returned scorers yourself

And have these questions:

# Can I walk the returned scorers to get to all non-null leaf scorers?
# Can I position the returned scorers on the current document by calling 
freq(), score() or something else?




> Remove Scorer.getChildren?
> --------------------------
>
>                 Key: LUCENE-6229
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6229
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Priority: Minor
>
> This API is used in a single place in our code base: 
> ToParentBlockJoinCollector. In addition, the usage is a bit buggy given that 
> using this API from a collector only works if setScorer is called with an 
> actual Scorer (and not eg. FakeScorer or BooleanScorer like you would get in 
> disjunctions) so it needs a custom IndexSearcher that does not use the 
> BulkScorer API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to