[
https://issues.apache.org/jira/browse/LUCENE-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14318287#comment-14318287
]
Robert Muir commented on LUCENE-6229:
-------------------------------------
I dont think this is guaranteed. Lets be clear about how this went down.
The functionality was added on LUCENE-2590, but was hardcoded to only work with
booleanscorer. Just look at the patch, you dont have to believe me. There was
also a lot of inconsistencies regarding various scorers. For example issues
like LUCENE-2686.
But we didnt slow down our core functionality, instead we waited until there
was a way to clean this stuff up non-intrusively. I added the getChildren API
to more scorers and fixed lots of bugs like this in issues like LUCENE-3505.
However, this api is *always* best effort. The one and only purpose of scorers
is to score hits. If someone can make disjunctionscorer 5% faster, and
completely break this getChildren API, I will be +1.
> Remove Scorer.getChildren?
> --------------------------
>
> Key: LUCENE-6229
> URL: https://issues.apache.org/jira/browse/LUCENE-6229
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Adrien Grand
> Priority: Minor
>
> This API is used in a single place in our code base:
> ToParentBlockJoinCollector. In addition, the usage is a bit buggy given that
> using this API from a collector only works if setScorer is called with an
> actual Scorer (and not eg. FakeScorer or BooleanScorer like you would get in
> disjunctions) so it needs a custom IndexSearcher that does not use the
> BulkScorer API.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
