[
https://issues.apache.org/jira/browse/LUCENE-6239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14317792#comment-14317792
]
Dawid Weiss commented on LUCENE-6239:
-------------------------------------
The patch looks good.
I still disagree with what's been said about the insecurity of our previous
usage of Unsafe -- we made safe measurements and fell back to sane defaults. No
failure of this code was ever reported (and wouldn't be). Now we don't make
measurements, but rely on (still sane!) assumptions. But these may or may not
hold true; {{-XX:ObjectAlignmentInBytes=16}}...
But ok, I shut up now.
> Remove RAMUsageEstimator Unsafe calls
> -------------------------------------
>
> Key: LUCENE-6239
> URL: https://issues.apache.org/jira/browse/LUCENE-6239
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Robert Muir
> Attachments: LUCENE-6239.patch, LUCENE-6239.patch
>
>
> This is unnecessary risk. We should remove this stuff, it is not needed here.
> We are a search engine, not a ram calculator.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
