[ 
https://issues.apache.org/jira/browse/LUCENE-6239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14316257#comment-14316257
 ] 

Robert Muir commented on LUCENE-6239:
-------------------------------------

{quote}
A similar argument could be made about the absolute need to compile and 
restrict the core to compact1 profile... why would you need that in a search 
library if it adds like a few milliseconds time at startup (once)?
{quote}

The main issue there is, people have complained in the past, that they cant use 
lucene on e.g. some mobile platform because it used XYZ api. My problem with 
supporting that in the past was, there was no way to "test" that used some 
restricted subset of the JDK apis. 

But now java 8 has this feature, which allows you to specify the subset, they 
provide this information in the javadocs, and the compiler will fail and all 
the infrastructure is in place, so I think we should only use what we need?

I think claiming that this only saves a few milliseconds is incorrect, perhaps 
you should read the article on the motivation for these profiles:
http://www.oracle.com/technetwork/articles/java/architect-profiles-2227131.html

But these profiles are unrelated to this issue. In this issue i just want to 
remove unnecessary Unsafe calls. its far more critical because Unsafe is well, 
Unsafe.

> Remove RAMUsageEstimator Unsafe calls
> -------------------------------------
>
>                 Key: LUCENE-6239
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6239
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>
> This is unnecessary risk. We should remove this stuff, it is not needed here. 
> We are a search engine, not a ram calculator.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to