[ 
https://issues.apache.org/jira/browse/LUCENE-6066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14287451#comment-14287451
 ] 

Michael McCandless commented on LUCENE-6066:
--------------------------------------------

Thanks Mark, the patch looks great.  I like the added test cases!  But I'm 
disappointed that Stayin' Alive didn't make the cut...

You could probably use CustomScoreQuery instead of having to make a whole Sim 
impl ... but no need to fix that now.

The patch has tabs ... need to change those to spaces ("ant precommit" will 
catch that).

The comment for the approximate version says it uses longs but it actually uses 
int right (String.hashCode())?

> Collector that manages diversity in search results
> --------------------------------------------------
>
>                 Key: LUCENE-6066
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6066
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/query/scoring
>            Reporter: Mark Harwood
>            Priority: Minor
>             Fix For: 5.0
>
>         Attachments: LUCENE-PQRemoveV6.patch, LUCENE-PQRemoveV7.patch
>
>
> This issue provides a new collector for situations where a client doesn't 
> want more than N matches for any given key (e.g. no more than 5 products from 
> any one retailer in a marketplace). In these circumstances a document that 
> was previously thought of as competitive during collection has to be removed 
> from the final PQ and replaced with another doc (eg a retailer who already 
> has 5 matches in the PQ receives a 6th match which is better than his 
> previous ones). This requires a new remove method on the existing 
> PriorityQueue class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to