[
https://issues.apache.org/jira/browse/SOLR-6847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shalin Shekhar Mangar updated SOLR-6847:
----------------------------------------
Attachment: SOLR-6847.patch
Patch with the fix. It is hard to write a test to trigger this situation
because it depends on the first replica returned by getReplicaProp to be a
different one so I'm going to leave it at this.
> LeaderInitiatedRecoveryThread compares wrong replica's state with lirState
> --------------------------------------------------------------------------
>
> Key: SOLR-6847
> URL: https://issues.apache.org/jira/browse/SOLR-6847
> Project: Solr
> Issue Type: Bug
> Components: SolrCloud
> Affects Versions: 4.10.2
> Reporter: Shalin Shekhar Mangar
> Priority: Minor
> Fix For: 5.0, Trunk
>
> Attachments: SOLR-6847.patch
>
>
> LeaderInitiatedRecoveryThread looks at a random replica to figure out if it
> should re-publish LIR state to "down". It does however publish the LIR state
> for the correct replica.
> The bug has always been there. The thread used ZkStateReader.getReplicaProps
> method with the coreName to find the correct replica. However, the coreName
> parameter in getReplicaProps was un-used and I removed it in SOLR-6240 but I
> didn't find and fix this bug then.
> The possible side-effects of this bug would be that we may be republish LIR
> state multiple times and/or in rare cases, cause double 'requestrecovery' to
> be executed on a replica.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
