[ 
https://issues.apache.org/jira/browse/SOLR-6326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14170612#comment-14170612
 ] 

Mikhail Khludnev commented on SOLR-6326:
----------------------------------------

[~pkeegan] patch seems effective, though isn't accomplished by test.

I feel like it's reversing dependency: core facility (IndexSearcher) is aware 
about the secondary one (EFF). I'd prefer EFF kicks IS. Why do you prefer 
commit for EFF reload, but not eff-reload handler?  

> ExternalFileFieldReloader and commits
> -------------------------------------
>
>                 Key: SOLR-6326
>                 URL: https://issues.apache.org/jira/browse/SOLR-6326
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Peter Keegan
>              Labels: difficulty-medium, externalfilefield, impact-medium
>         Attachments: SOLR-6326.patch
>
>
> When there are multiple 'external file field' files available, Solr will 
> reload the last one (lexicographically) with a commit, but only if changes 
> were made to the index. Otherwise, it skips the reload and logs: "No 
> uncommitted changes. Skipping IW.commit." 
> IndexWriter.hasUncommittedChanges() returns false, but new external files 
> should be reloaded with commits.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to