[ 
https://issues.apache.org/jira/browse/SOLR-6326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14136293#comment-14136293
 ] 

Steve Rowe commented on SOLR-6326:
----------------------------------

Actually, looking at {{DirectUpdateHandler2.commit()}}, "postCommit" listeners 
are called regardless of whether a commit was actually performed, so a new 
"preCommit" event type isn't necessary.  {{ExternalFileFieldReloader}} could 
override {{AbstractSolrEventListener.postCommit()}} and handle reloading there.

There is no support currently for registering "postSoftCommit" event listeners 
in the solrconfig.xml {{<updateHandler>}} section, so I think that'd have to be 
added, along with {{ExternalFileFieldReloader}} overriding 
{{AbstractSolrEventListener.postSoftCommit()}}, to provide the same 
functionality as the current "newSearcher" listener.  The "firstListener" 
callback would still be necessary, since no (soft) commit will have happened on 
startup.

> ExternalFileFieldReloader and commits
> -------------------------------------
>
>                 Key: SOLR-6326
>                 URL: https://issues.apache.org/jira/browse/SOLR-6326
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Peter Keegan
>              Labels: difficulty-medium, externalfilefield, impact-medium
>
> When there are multiple 'external file field' files available, Solr will 
> reload the last one (lexicographically) with a commit, but only if changes 
> were made to the index. Otherwise, it skips the reload and logs: "No 
> uncommitted changes. Skipping IW.commit." 
> IndexWriter.hasUncommittedChanges() returns false, but new external files 
> should be reloaded with commits.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to