[
https://issues.apache.org/jira/browse/SOLR-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hoss Man updated SOLR-2894:
---------------------------
Attachment: SOLR-2894.patch
Making good progress (only ~1600 lines of diff left to review!)
updates in this patch...
* PivotFacetFieldValueCollection
** some javadocs
** refactor away method: nonNullValueIterator()
*** only called in one place
* PivotFacetField
** some javaddocs
** made createFromListOfNamedLists smart enough to return null on null input
*** simplified PivotFacetValue.createFromNamedList
** made contributeFromShard smart enough to be a no-op on null input
*** simplified all callers (PivotFacet & PivotFacetValue)
** made some vars final where possible via refactoring constructor &
createFromListOfNamedLists
** refactor skipRefinementAtThisLevel out of the method an up to an instance
var since it never changes once the facet params are set in the constructor
** consolidate skipRefinementAtThisLevel + hasBeenRefined into a single var:
needRefinementAtThisLevel
** simplify BitSet iteration (nextSetBit is always < length)
*** processDefiniteCandidateElement
*** processPossibleCandidateElement
* PivotFacetValue
** some javadocs
** made variables private and added method accessors (w/jdocs) as needed
*** updated other classes as needed to call these new methods instead of the
old pub vars
** made some vars final where possible via refactoring createFromNamedList &
constructor
* PivotFacet
** some javadocs
** added getQueuedRefinements(int)
** made some variables final where possible
** renamed noRefinementsRequired -> isRefinementsRequired
** eliminate unused method: areAnyRefinementsQueued
* FacetComponent
** switched direct use of PivotFacet.queuedRefinements to use
PivotFacet.getQueuedRefinements
*** simplified error checking in several places
----
One new question i want to go back and revisit later...
* do we really need to track "knownShards" in PivotFacet ?
** ResponseBuilder already maintains a String[] of all shards, getShardNum
derived from it
** can't we just loop from 0 to shards.length? does it ever matter if a shard
hasn't participated?
** ie: is it really important that we skip any "unset bits" in knownShards when
looping? (all the current usages seem safe even if a shard has no data for the
current pivot)
> Implement distributed pivot faceting
> ------------------------------------
>
> Key: SOLR-2894
> URL: https://issues.apache.org/jira/browse/SOLR-2894
> Project: Solr
> Issue Type: Improvement
> Reporter: Erik Hatcher
> Assignee: Hoss Man
> Fix For: 4.9, 5.0
>
> Attachments: SOLR-2894-mincount-minification.patch,
> SOLR-2894-reworked.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894_cloud_test.patch,
> dateToObject.patch, pivot_mincount_problem.sh
>
>
> Following up on SOLR-792, pivot faceting currently only supports
> undistributed mode. Distributed pivot faceting needs to be implemented.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
